teardown strands the boot daemon when config no longer has dedicated addresses #2

New issue

Closed

opened 2026-08-11 10:25:35 +00:00 by aav · 0 comments

aav commented

2026-08-11 10:25:35 +00:00

Owner

apply_teardown (src/setup.rs:389) returns early when the current config has no dedicated addresses, skipping remove_boot_daemon and the /etc/hosts block removal. An installed boot daemon then survives the teardown the README says always removes it.

Failure scenario: user does sudo silta setup --persistent, later rewrites the config to plain 127.0.0.1 forwards (dropping bind_address), then runs sudo silta teardown to clean up. plan() is empty, teardown prints "nothing to remove" and exits without touching the LaunchDaemon plist, the feth99 interface, or the /etc/hosts block. The root boot daemon keeps running setup with the new config at every boot, and there is no silta command left that will remove it.

Fix direction: teardown should remove the daemon and any existing hosts block by interface name regardless of whether the current config declares dedicated addresses.

Source: high-effort code review, CONFIRMED. Area: setup.

`apply_teardown` (src/setup.rs:389) returns early when the current config has no dedicated addresses, skipping `remove_boot_daemon` and the /etc/hosts block removal. An installed boot daemon then survives the teardown the README says always removes it. **Failure scenario:** user does `sudo silta setup --persistent`, later rewrites the config to plain 127.0.0.1 forwards (dropping bind_address), then runs `sudo silta teardown` to clean up. `plan()` is empty, teardown prints "nothing to remove" and exits without touching the LaunchDaemon plist, the feth99 interface, or the /etc/hosts block. The root boot daemon keeps running setup with the new config at every boot, and there is no silta command left that will remove it. **Fix direction:** teardown should remove the daemon and any existing hosts block by interface name regardless of whether the current config declares dedicated addresses. Source: high-effort code review, CONFIRMED. Area: setup.

aav added the

bug

priority

major

labels

2026-08-11 10:25:35 +00:00

aav self-assigned this

2026-08-11 10:27:24 +00:00

aav referenced this issue from a commit

2026-08-11 11:03:14 +00:00

Tear down the interface and daemon by record, not by current addresses

aav closed this issue