--persistent ownership check runs after the host is already mutated #3

New issue

Closed

opened 2026-08-11 10:25:36 +00:00 by aav · 0 comments

aav commented

2026-08-11 10:25:36 +00:00

Owner

The --persistent root-ownership check runs last, after the interface, addresses, and /etc/hosts block are already created (src/setup.rs:227 onward). A refusal leaves setup half-applied, and a corrected re-run is rejected because the interface now exists.

Failure scenario: user runs sudo silta setup --persistent with the binary still in target/release. The interface is created, addresses added, and /etc/hosts written, then install_daemon bails on the ownership check and the command exits nonzero. After installing the binary to /usr/local/bin and re-running, apply_setup bails with "feth99 already exists. run silta teardown first", forcing a teardown (killing any live forwards) and a second setup just to add the daemon.

Fix direction: validate the persistence preconditions (binary/config ownership) before mutating any host state.

Source: high-effort code review, CONFIRMED. Area: setup.

The `--persistent` root-ownership check runs last, after the interface, addresses, and /etc/hosts block are already created (src/setup.rs:227 onward). A refusal leaves setup half-applied, and a corrected re-run is rejected because the interface now exists. **Failure scenario:** user runs `sudo silta setup --persistent` with the binary still in target/release. The interface is created, addresses added, and /etc/hosts written, then `install_daemon` bails on the ownership check and the command exits nonzero. After installing the binary to /usr/local/bin and re-running, `apply_setup` bails with "feth99 already exists. run silta teardown first", forcing a teardown (killing any live forwards) and a second setup just to add the daemon. **Fix direction:** validate the persistence preconditions (binary/config ownership) before mutating any host state. Source: high-effort code review, CONFIRMED. Area: setup.

aav added the

bug

priority

major

labels

2026-08-11 10:25:36 +00:00

aav self-assigned this

2026-08-11 10:27:24 +00:00

aav referenced this issue from a commit

2026-08-11 11:03:14 +00:00

Validate --persistent ownership before mutating the host

aav closed this issue