inspect_target duplicates resolve_service selector and ready-pod logic #9

New issue

Closed

opened 2026-08-11 10:25:49 +00:00 by aav · 0 comments

aav commented

2026-08-11 10:25:49 +00:00

Owner

inspect_target's Service arm (src/k8s.rs:281) re-implements the selector-string build and ready-pod listing that resolve_service already has (src/k8s.rs:332-347).

Failure scenario: two copies of the selector formatting and pod-picking logic drift. A fix to selector escaping or Ready-pod selection applied to resolve_service is missed in inspect_target, so silta describe shows hints from a different pod than the one run() would actually forward to.

Fix direction: extract the shared selector-build + ready-pod-pick into a helper both call.

Source: high-effort code review, CONFIRMED. Area: k8s.

`inspect_target`'s Service arm (src/k8s.rs:281) re-implements the selector-string build and ready-pod listing that `resolve_service` already has (src/k8s.rs:332-347). **Failure scenario:** two copies of the selector formatting and pod-picking logic drift. A fix to selector escaping or Ready-pod selection applied to `resolve_service` is missed in `inspect_target`, so `silta describe` shows hints from a different pod than the one `run()` would actually forward to. **Fix direction:** extract the shared selector-build + ready-pod-pick into a helper both call. Source: high-effort code review, CONFIRMED. Area: k8s.

aav added the

refactor

priority

minor

labels

2026-08-11 10:25:49 +00:00

aav self-assigned this

2026-08-11 10:27:24 +00:00

aav referenced this issue from a commit

2026-08-11 11:10:38 +00:00

Share the selector and ready-pod lookup in k8s

aav closed this issue